Skip to content

Resume partial release drafts from verified existing artifacts - #593

Draft
waveywaves wants to merge 13 commits into
tektoncd:mainfrom
waveywaves:fix-release-verified-recovery
Draft

waveywaves wants to merge 13 commits into
tektoncd:mainfrom
waveywaves:fix-release-verified-recovery

Conversation

@waveywaves

@waveywaves waveywaves commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Changes

Resume a missing or partial release draft from existing signed artifacts,
instead of deleting partial state or rebuilding the same version.

  • Verify a complete versioned bucket bundle against the approved commit,
    image digest and independently configured signing key before any mutation.
  • Require maintainer environment approval, the trusted main workflow, and
    actual tekton-robot repository access.
  • Check paginated drafts and exact lightweight or annotated tag source;
    reject published releases, ambiguous state and conflicting attachments.
  • Generate notes for a missing draft, preserve existing notes and matching
    assets, and upload only missing verified files without clobbering.
  • Verify the completed draft again and leave publication/latest promotion
    to the separately approved finalization workflow.
  • Reuse the same tag resolver as verification and finalization so all three
    paths reject conflicting lightweight and annotated tags consistently.
  • Wire Kueue to the authenticated shared preflight task and check its
    versioned container image as well as tags, drafts and all three bucket files.

Incomplete or unsigned bundles fail closed: recovery does not invent missing
artifacts or signatures. The existing builder state must be preserved in that
case.

Deterministic regression suites cover recovery, trust and conflict boundaries.
All 30 recovery, 83 verifier and 23 finalization cases pass, including repeated
repair of recovery-generated notes.
The bucket verification mode also passed against the actual public v0.4.3
artifacts and signatures; the QA key is not a production trust bootstrap.
No live recovery, publication, promotion or infrastructure apply ran.

Dependencies: merge #592 and tektoncd/plumbing#3809 first. Provision the
approval environment and independent signing trust from
tektoncd/plumbing#3808 before running recovery.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Recognize DSSE provenance entries and fail when no provenance can be found instead of substituting an image-signature entry. Pin the shared release task with corrected attestation instructions.

Depends on tektoncd/plumbing#3807.

Assisted-by: OmO
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Check metadata, bucket copies, image platforms and signed provenance before retaining immutable verification receipts.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Remove latest inputs and publication paths; reject legacy promotion before side effects and verify the shipped guard during release configuration checks.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Install the immutable manifest and image, require webhook mutation, admission and PipelineRun success, and retain diagnostics while cleaning only the owned cluster.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Use PipelineRunPending from the actual admission response and reject the incorrect Pending value in the deterministic boundary test.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Verify the exact candidate and smoke its published artifacts before optional latest promotion. Bind repaired provenance notes to verified payloads and retain publication state during repair.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Watch old Pod deletion and the Service endpoint switch after rollout instead of relying only on Deployment availability.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Print candidate identifiers without Markdown command delimiters so the required workflow shell lint accepts the summary.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Verify the signed versioned bundle before restoring only missing draft assets; reject conflicting source and bytes. Wire authenticated preflight and retain all existing build evidence.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from waveywaves after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.81%. Comparing base (c0c2d21) to head (12231e2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #593       +/-   ##
===========================================
+ Coverage   55.69%   73.81%   +18.12%     
===========================================
  Files          16       16               
  Lines        1203     1203               
===========================================
+ Hits          670      888      +218     
+ Misses        497      253      -244     
- Partials       36       62       +26     
Flag Coverage Δ
e2e-tests 52.79% <ø> (?)
unit-tests 55.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c2d21...12231e2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Peel existing tags and fail on source conflicts or lookup errors. Permit missing tags only for candidates that have not been published.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Append the attestation boundary so a finalized recovery draft can be repaired repeatedly without losing its generated notes.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Reuse the verifier tag check before promotion and after publishing, and reject a tag changed during candidate checks.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Use the same checked tag lookup for recovery, artifact verification and finalization instead of retaining a separate implementation.

Assisted-by: OpenAI
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants